zddr commented on code in PR #34548: URL: https://github.com/apache/doris/pull/34548#discussion_r1602580842
########## fe/fe-core/src/main/java/org/apache/doris/event/EventProcessor.java: ########## @@ -0,0 +1,57 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.event; + +import com.google.common.collect.Sets; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.Objects; +import java.util.Set; + +public class EventProcessor { + + private static final Logger LOG = LogManager.getLogger(EventProcessor.class); + + private Set<EventListener> listeners = Sets.newHashSet(); + + public EventProcessor(EventListener... args) { + for (EventListener listener : args) { + this.listeners.add(listener); + } + } + + public boolean processEvent(Event event) { + Objects.requireNonNull(event); + if (LOG.isDebugEnabled()) { + LOG.debug("processEvent: {}", event); + } + boolean result = true; + for (EventListener listener : listeners) { + try { + listener.processEvent(event); Review Comment: Here, we need to wait for each listener to complete its execution. If there are many listeners, each listener can be run with one thread, and then the main thread waits for all threads to finish executing before returning. Currently, there is only one listener. Can we use synchronous logic to handle it first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
