jacktengg commented on code in PR #34689:
URL: https://github.com/apache/doris/pull/34689#discussion_r1602523180
##########
be/src/vec/data_types/data_type_date.h:
##########
@@ -60,6 +60,12 @@ class DataTypeDate final : public DataTypeNumberBase<Int64> {
bool equals(const IDataType& rhs) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
+ std::string to_string(Int64 int_val) const {
+ doris::VecDateTimeValue value = binary_cast<Int64,
doris::VecDateTimeValue>(int_val);
+ char buf[64];
Review Comment:
DataTypeDate is actually DataTypeNumberBase<Int64>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
