github-actions[bot] commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1601669912
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -282,14 +282,20 @@ Status Segment::_parse_footer(SegmentFooterPB* footer) {
return Status::OK();
}
-Status Segment::_load_pk_bloom_filter() {
+Status Segment::_load_pk_bloom_filter(bool is_segment_use_cache) {
Review Comment:
warning: method '_load_pk_bloom_filter' can be made const
[readability-make-member-function-const]
```suggestion
Status Segment::_load_pk_bloom_filter(bool is_segment_use_cache) const {
```
be/src/olap/rowset/segment_v2/segment.h:196:
```diff
- Status _load_pk_bloom_filter(bool is_segment_use_cache);
+ Status _load_pk_bloom_filter(bool is_segment_use_cache) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
