github-actions[bot] commented on code in PR #34925:
URL: https://github.com/apache/doris/pull/34925#discussion_r1601571859
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -138,23 +138,20 @@
for (uint32_t i = 0; i < column.get_subtype_count(); ++i) {
_init_column_meta(meta->add_children_columns(), column_id,
column.get_sub_column(i));
}
- // add sparse column to footer
- for (uint32_t i = 0; i < column.num_sparse_columns(); i++) {
- _init_column_meta(meta->add_sparse_columns(), -1,
column.sparse_column_at(i));
- }
}
-Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column) {
+Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column,
Review Comment:
warning: function '_create_column_writer' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:142:** 81 lines
including whitespace and comments (threshold 80)
```cpp
Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column,
^
```
</details>
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -709,16 +707,122 @@
return Status::OK();
}
+Status
VerticalSegmentWriter::_append_block_with_variant_subcolumns(RowsInBlock& data)
{
Review Comment:
warning: function '_append_block_with_variant_subcolumns' exceeds
recommended size/complexity thresholds [readability-function-size]
```cpp
Status
VerticalSegmentWriter::_append_block_with_variant_subcolumns(RowsInBlock& data)
{
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:709:** 98 lines
including whitespace and comments (threshold 80)
```cpp
Status
VerticalSegmentWriter::_append_block_with_variant_subcolumns(RowsInBlock& data)
{
^
```
</details>
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -308,13 +305,14 @@
// 2.2 build read plan to read by batch
// 2.3 fill block
// 3. set columns to data convertor and then write all columns
-Status VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock&
data) {
+Status VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock&
data,
Review Comment:
warning: function '_append_block_with_partial_content' has cognitive
complexity of 57 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status
VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock& data,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:351:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (const vectorized::ColumnWithTypeAndName* delete_sign_column =
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:356:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (delete_sign_col.size() >= data.row_pos + data.num_rows) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:363:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("VerticalSegmentWriter._append_block_with_partial_content.sleep",
^
```
**be/src/util/debug_points.h:35:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:363:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("VerticalSegmentWriter._append_block_with_partial_content.sleep",
^
```
**be/src/util/debug_points.h:37:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:367:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (specified_rowsets.size() != _mow_context->rowset_ids.size()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:376:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:387:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
for (size_t block_pos = data.row_pos; block_pos < data.row_pos +
data.num_rows; block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:398:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:404:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (!_tablet_schema->has_sequence_col() || have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:405:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:405:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:410:** +1
```cpp
(delete_sign_column_data != nullptr &&
delete_sign_column_data[block_pos] != 0);
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:417:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_NOT_FOUND>()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:418:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:424:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:425:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if
(!_opts.rowset_ctx->partial_update_info->can_insert_new_rows_in_partial_update)
{
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:446:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok() && !st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:456:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (have_delete_sign && !_tablet_schema->has_sequence_col()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:459:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:466:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:472:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:479:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:486:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:486:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:489:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->store_row_column()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:513:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->has_sequence_col() && !have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:520:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_num_rows_written != data.row_pos ||
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:527:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t block_pos = data.row_pos; block_pos < data.row_pos +
data.num_rows;
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:531:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:531:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -308,13 +305,14 @@
// 2.2 build read plan to read by batch
// 2.3 fill block
// 3. set columns to data convertor and then write all columns
-Status VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock&
data) {
+Status VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock&
data,
Review Comment:
warning: function '_append_block_with_partial_content' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status
VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock& data,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:307:** 233 lines
including whitespace and comments (threshold 80)
```cpp
Status
VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock& data,
^
```
</details>
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -138,23 +138,20 @@ void
VerticalSegmentWriter::_init_column_meta(ColumnMetaPB* meta, uint32_t colum
for (uint32_t i = 0; i < column.get_subtype_count(); ++i) {
_init_column_meta(meta->add_children_columns(), column_id,
column.get_sub_column(i));
}
- // add sparse column to footer
- for (uint32_t i = 0; i < column.num_sparse_columns(); i++) {
- _init_column_meta(meta->add_sparse_columns(), -1,
column.sparse_column_at(i));
- }
}
-Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column) {
+Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column,
Review Comment:
warning: function '_create_column_writer' has cognitive complexity of 51
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status VerticalSegmentWriter::_create_column_writer(uint32_t cid, const
TabletColumn& column,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:154:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (tablet_index) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:163:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_opts.rowset_ctx != nullptr) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:168:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_opts.write_type == DataWriteType::TYPE_DIRECT &&
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:174:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (!InvertedIndexColumnWriter::check_column_valid(column)) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:202:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(STRUCT, "struct")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:202:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(STRUCT, "struct")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:202:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(STRUCT, "struct")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:203:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(ARRAY, "array")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:203:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(ARRAY, "array")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:203:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(ARRAY, "array")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:204:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(JSONB, "jsonb")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:204:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(JSONB, "jsonb")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:204:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(JSONB, "jsonb")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:205:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(AGG_STATE, "agg_state")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:205:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(AGG_STATE, "agg_state")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:205:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(AGG_STATE, "agg_state")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:206:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(MAP, "map")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:206:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(MAP, "map")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:206:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(MAP, "map")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:207:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(OBJECT, "object")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:207:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(OBJECT, "object")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:207:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(OBJECT, "object")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:208:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(HLL, "hll")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:208:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(HLL, "hll")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:208:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(HLL, "hll")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:209:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
CHECK_FIELD_TYPE(QUANTILE_STATE, "quantile_state")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:192:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (column.type() == FieldType::OLAP_FIELD_TYPE_##TYPE) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:209:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(QUANTILE_STATE, "quantile_state")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:194:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bloom_filter) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:209:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
CHECK_FIELD_TYPE(QUANTILE_STATE, "quantile_state")
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:197:** expanded
from macro 'CHECK_FIELD_TYPE'
```cpp
if (opts.need_bitmap_index) {
\
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:213:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (column.is_row_store_column()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:218:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(ColumnWriter::create(opts, &column, _file_writer,
&writer));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:218:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(ColumnWriter::create(opts, &column, _file_writer,
&writer));
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:219:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(writer->init());
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:219:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(writer->init());
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
