hubgeter commented on code in PR #34814:
URL: https://github.com/apache/doris/pull/34814#discussion_r1599699583
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1747,9 +1747,16 @@ Status OrcReader::get_next_block(Block* block, size_t*
read_rows, bool* eof) {
}
} else {
if (_delete_rows_filter_ptr) {
+
_execute_filter_position_delete_rowids(*_delete_rows_filter_ptr);
RETURN_IF_CATCH_EXCEPTION(Block::filter_block_internal(block,
columns_to_filter,
(*_delete_rows_filter_ptr)));
+ } else {
+ std::unique_ptr<IColumn::Filter> filter(new
IColumn::Filter(block->rows(), 1));
Review Comment:
_delete_rows_filter_ptr be used in transactional hive orc , not position
delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
