github-actions[bot] commented on code in PR #34799: URL: https://github.com/apache/doris/pull/34799#discussion_r1599303010
########## be/src/util/jni-util.cpp: ########## @@ -247,6 +248,9 @@ size_t JniUtil::get_max_jni_heap_memory_size() { #if defined(USE_LIBHDFS3) || defined(BE_TEST) return std::numeric_limits<size_t>::max(); #else + static std::once_flag parse_max_heap_memory_size_from_jvm_flag; Review Comment: warning: 'parse_max_heap_memory_size_from_jvm_flag' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace] ```suggestion std::once_flag parse_max_heap_memory_size_from_jvm_flag; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org