wangbo commented on a change in pull request #7795: URL: https://github.com/apache/incubator-doris/pull/7795#discussion_r787345637
########## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ########## @@ -671,7 +673,7 @@ void SegmentIterator::_vec_init_lazy_materialization() { } else if (is_predicate_column_exists && !is_non_predicate_column_exists) { _first_read_column_ids.assign(pred_column_ids.cbegin(), pred_column_ids.cend()); - } else if (!is_predicate_column_exists && is_non_predicate_column_exists) { + } else if (!is_predicate_column_exists) { Review comment: I think maybe ```is_non_predicate_column_exists``` can be removed, and then add some comment to make it clear -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org