github-actions[bot] commented on code in PR #34735:
URL: https://github.com/apache/doris/pull/34735#discussion_r1597487093
##########
cloud/src/meta-service/doris_txn.cpp:
##########
@@ -29,7 +31,8 @@ int get_txn_id_from_fdb_ts(std::string_view fdb_vts, int64_t*
txn_id) {
// byte addr 0 1 2 3 4 5 6 7 8 9
int64_t ver = *reinterpret_cast<const int64_t*>(fdb_vts.data());
- // static_assert(std::endian::little); // Since c++20
+ // TODO(gavin): implementation for big-endian or make it endian-independent
+ static_assert(std::endian::native == std::endian::little); // Since c++20
Review Comment:
warning: no member named 'endian' in namespace 'std' [clang-diagnostic-error]
```cpp
static_assert(std::endian::native == std::endian::little); // Since c++20
^
```
##########
cloud/src/meta-service/doris_txn.cpp:
##########
@@ -29,7 +31,8 @@
// byte addr 0 1 2 3 4 5 6 7 8 9
int64_t ver = *reinterpret_cast<const int64_t*>(fdb_vts.data());
- // static_assert(std::endian::little); // Since c++20
+ // TODO(gavin): implementation for big-endian or make it endian-independent
+ static_assert(std::endian::native == std::endian::little); // Since c++20
Review Comment:
warning: no member named 'endian' in namespace 'std' [clang-diagnostic-error]
```cpp
static_assert(std::endian::native == std::endian::little); // Since c++20
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
