zuochunwei commented on a change in pull request #7751:
URL: https://github.com/apache/incubator-doris/pull/7751#discussion_r785674394
##########
File path: be/src/vec/columns/column_nullable.cpp
##########
@@ -131,6 +131,12 @@ void ColumnNullable::insert_range_from(const IColumn& src,
size_t start, size_t
get_nested_column().insert_range_from(*nullable_col.nested_column, start,
length);
}
+void ColumnNullable::insert_indices_from(const IColumn& src, const int*
indices_begin, const int* indices_end) {
+ for (auto x = indices_begin; x != indices_end; ++x) {
Review comment:
ok
##########
File path: be/src/vec/columns/column_vector.cpp
##########
@@ -221,6 +222,15 @@ void ColumnVector<T>::insert_range_from(const IColumn&
src, size_t start, size_t
memcpy(data.data() + old_size, &src_vec.data[start], length *
sizeof(data[0]));
}
+template <typename T>
+void ColumnVector<T>::insert_indices_from(const IColumn& src, const int*
indices_begin, const int* indices_end) {
+ const Self& src_vec = assert_cast<const Self&>(src);
Review comment:
ok
##########
File path: be/src/vec/columns/column_decimal.h
##########
@@ -95,6 +95,13 @@ class ColumnDecimal final : public
COWHelper<ColumnVectorHelper, ColumnDecimal<T
void insert_from(const IColumn& src, size_t n) override {
data.push_back(static_cast<const Self&>(src).get_data()[n]);
}
+
+ void insert_indices_from(const IColumn& src, const int* indices_begin,
const int* indices_end) override {
+ for (auto x = indices_begin; x != indices_end; ++x) {
+ Self::insert_from(src, *x);
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
