Lchangliang commented on code in PR #34526: URL: https://github.com/apache/doris/pull/34526#discussion_r1593541497
########## be/src/olap/rowset/segment_v2/segment.cpp: ########## @@ -408,6 +408,7 @@ Status Segment::_create_column_readers(const SegmentFooterPB& footer) { RETURN_IF_ERROR(ColumnReader::create(opts, footer.columns(iter->second), footer.num_rows(), _file_reader, &reader)); _column_readers.emplace(column.unique_id(), std::move(reader)); + _meta_mem_usage += config::estimated_mem_per_column_reader; Review Comment: It still has some unique_ptr/shared_ptr object and the object `SubcolumnColumnReaders`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org