github-actions[bot] commented on code in PR #34457:
URL: https://github.com/apache/doris/pull/34457#discussion_r1591923447
##########
be/src/vec/runtime/vsorted_run_merger.cpp:
##########
@@ -98,6 +98,16 @@ Status VSortedRunMerger::prepare(const
vector<BlockSupplier>& input_runs) {
}
Status VSortedRunMerger::get_next(Block* output_block, bool* eos) {
+ try {
+ get_next_data(output_block, eos);
+ } catch (const std::runtime_error& e) {
+ return Status::RuntimeError(e.what());
+ } catch (...) {
+ return Status::RuntimeError("SortMerger error");
+ }
+}
+
+Status VSortedRunMerger::get_next_data(Block* output_block, bool* eos) {
Review Comment:
warning: function 'get_next_data' has cognitive complexity of 58 (threshold
50) [readability-function-cognitive-complexity]
```cpp
Status VSortedRunMerger::get_next_data(Block* output_block, bool* eos) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vsorted_run_merger.cpp:115:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_pending_cursor != nullptr) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:117:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (has_next_block(cursor)) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:123:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_priority_queue.empty()) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:126:** +1, nesting level
increased to 1
```cpp
} else if (_priority_queue.size() == 1) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:128:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (_offset != 0 && current->block_ptr() != nullptr) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:128:** +1
```cpp
while (_offset != 0 && current->block_ptr() != nullptr) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:129:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_offset >= current->rows - current->pos) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:131:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (_pipeline_engine_enabled) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:137:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:143:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (current->is_first()) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:144:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (current->block_ptr() != nullptr) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:146:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (_pipeline_engine_enabled) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:152:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:155:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:156:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (current->block_ptr() != nullptr) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:157:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
for (int i = 0; i < current->all_columns.size(); i++) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:163:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (_pipeline_engine_enabled) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:169:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:173:** +1, nesting level
increased to 1
```cpp
} else {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:179:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (num_columns != merged_columns.size()) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:189:** nesting level increased
to 2
```cpp
auto do_insert = [&]() {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:191:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
for (size_t i = 0; i < num_columns; ++i) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:204:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (merged_rows != _batch_size && !_priority_queue.empty()) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:208:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_offset > 0) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:210:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:216:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!next_heap(current)) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:224:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (merged_rows == 0) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:231:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_limit != -1 && _num_rows_returned >= _limit) {
^
```
**be/src/vec/runtime/vsorted_run_merger.cpp:231:** +1
```cpp
if (_limit != -1 && _num_rows_returned >= _limit) {
^
```
</details>
##########
be/src/vec/runtime/vsorted_run_merger.cpp:
##########
@@ -98,6 +98,16 @@
}
Status VSortedRunMerger::get_next(Block* output_block, bool* eos) {
+ try {
+ get_next_data(output_block, eos);
+ } catch (const std::runtime_error& e) {
+ return Status::RuntimeError(e.what());
+ } catch (...) {
+ return Status::RuntimeError("SortMerger error");
+ }
+}
+
+Status VSortedRunMerger::get_next_data(Block* output_block, bool* eos) {
Review Comment:
warning: function 'get_next_data' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status VSortedRunMerger::get_next_data(Block* output_block, bool* eos) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vsorted_run_merger.cpp:109:** 127 lines including
whitespace and comments (threshold 80)
```cpp
Status VSortedRunMerger::get_next_data(Block* output_block, bool* eos) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
