zhiqiang-hhhh commented on code in PR #34391: URL: https://github.com/apache/doris/pull/34391#discussion_r1590930677
########## be/src/vec/functions/round.h: ########## @@ -564,16 +554,9 @@ struct Dispatcher { } } - // NOTE: This function is only tested for truncate - // DO NOT USE THIS METHOD FOR OTHER ROUNDING BASED FUNCTION UNTIL YOU KNOW EXACTLY WHAT YOU ARE DOING !!! only test for truncate static ColumnPtr apply_const_vec(const ColumnConst* const_col_general, Review Comment: not ceil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org