github-actions[bot] commented on code in PR #34397:
URL: https://github.com/apache/doris/pull/34397#discussion_r1590320880
##########
be/src/common/status.h:
##########
@@ -301,15 +306,39 @@ extern ErrorCodeState
error_states[MAX_ERROR_CODE_DEFINE_NUM];
class ErrorCodeInitializer {
public:
- ErrorCodeInitializer() {
-#define M(NAME, ENABLESTACKTRACE) error_states[TStatusCode::NAME].stacktrace =
ENABLESTACKTRACE;
+ ErrorCodeInitializer(int temp) : signal_value(temp) {
Review Comment:
warning: function 'ErrorCodeInitializer' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
ErrorCodeInitializer(int temp) : signal_value(temp) {
^
```
<details>
<summary>Additional context</summary>
**be/src/common/status.h:308:** 892 statements (threshold 800)
```cpp
ErrorCodeInitializer(int temp) : signal_value(temp) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
