xiaokang commented on code in PR #33982:
URL: https://github.com/apache/doris/pull/33982#discussion_r1582007867
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -382,6 +378,26 @@ InvertedIndexReaderType FullTextIndexReader::type() {
return InvertedIndexReaderType::FULLTEXT;
}
+void FullTextIndexReader::setup_analyzer_lowercase(
Review Comment:
duplicate function to writer
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -382,6 +378,26 @@ InvertedIndexReaderType FullTextIndexReader::type() {
return InvertedIndexReaderType::FULLTEXT;
}
+void FullTextIndexReader::setup_analyzer_lowercase(
+ std::unique_ptr<lucene::analysis::Analyzer>& analyzer,
+ const std::map<string, string>& properties) {
+ auto lowercase = get_parser_lowercase_from_properties(properties);
+ if (lowercase == INVERTED_INDEX_PARSER_TRUE) {
+ analyzer->set_lowercase(true);
+ } else if (lowercase == INVERTED_INDEX_PARSER_FALSE) {
+ analyzer->set_lowercase(false);
+ }
+}
+
+void FullTextIndexReader::setup_analyzer_use_stopwords(
+ std::unique_ptr<lucene::analysis::Analyzer>& analyzer,
+ const std::map<string, string>& properties) {
+ auto stop_words = get_parser_stopwords_from_properties(properties);
+ if (stop_words == "none") {
+ analyzer->use_stopwords(false);
Review Comment:
change true/false to string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
