weajun commented on a change in pull request #7568:
URL: https://github.com/apache/incubator-doris/pull/7568#discussion_r780127972
##########
File path:
extension/DataX/doriswriter/src/main/java/com/alibaba/datax/plugin/writer/doriswriter/DorisJsonCodec.java
##########
@@ -46,5 +44,4 @@ public String serialize(final Record row) {
}
return JSON.toJSONString(rowMap);
}
-
-}
\ No newline at end of file
+}
Review comment:
> We can create `final Map<String, Object> rowMap` in constructor of
`DorisJsonCodec` and reuse it in `serialize()`. No need to create it for every
row.
thanks,I have optimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
