caiconghui commented on a change in pull request #7240:
URL: https://github.com/apache/incubator-doris/pull/7240#discussion_r777279965
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
##########
@@ -240,16 +240,6 @@ protected boolean
checkCommitInfo(RLTaskTxnCommitAttachment rlTaskTxnCommitAttac
return true;
}
- if (txnStatusChangeReason != null && txnStatusChangeReason ==
TransactionState.TxnStatusChangeReason.NO_PARTITIONS) {
- // Because the max_filter_ratio of routine load task is always 1.
- // Therefore, under normal circumstances, routine load task will
not return the error "too many filtered rows".
- // If no data is imported, the error "all partitions have no load
data" may only be returned.
- // In this case, the status of the transaction is ABORTED,
- // but we still need to update the offset to skip these error
lines.
- Preconditions.checkState(txnState.getTransactionStatus() ==
TransactionStatus.ABORTED, txnState.getTransactionStatus());
- return true;
Review comment:
when we can commit empty rowset, txnStatusChangeReason would be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
