zhiqiang-hhhh commented on code in PR #33968: URL: https://github.com/apache/doris/pull/33968#discussion_r1574390854
########## be/src/vec/functions/function_ip.h: ########## @@ -856,16 +856,19 @@ class FunctionIPv6CIDRToRange : public IFunction { WhichDataType addr_type(addr_column_with_type_and_name.type); WhichDataType cidr_type(cidr_column_with_type_and_name.type); const ColumnPtr& addr_column = addr_column_with_type_and_name.column; - const ColumnPtr& cidr_column = cidr_column_with_type_and_name.column; + const auto& [cidr_column, col_const] = + unpack_if_const(cidr_column_with_type_and_name.column); Review Comment: do same thing to ip_column, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org