github-actions[bot] commented on code in PR #33880: URL: https://github.com/apache/doris/pull/33880#discussion_r1571821551
########## be/src/io/fs/stream_load_pipe.h: ########## @@ -83,6 +83,10 @@ class StreamLoadPipe : public MessageBodySink, public FileReader { // used for pipeline load, which use TUniqueId(lo: query_id.lo + fragment_id, hi: query_id.hi) as pipe_id static TUniqueId calculate_pipe_id(const UniqueId& query_id, int32_t fragment_id); + size_t max_capacity() const { return _max_buffered_bytes; } Review Comment: warning: function 'max_capacity' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] size_t max_capacity() const { return _max_buffered_bytes; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org