github-actions[bot] commented on code in PR #32789:
URL: https://github.com/apache/doris/pull/32789#discussion_r1571730569
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:
##########
@@ -164,7 +166,8 @@ void PipelineXFragmentContext::cancel(const
PPlanFragmentCancelReason& reason,
}
}
-Status PipelineXFragmentContext::prepare(const doris::TPipelineFragmentParams&
request) {
+Status PipelineXFragmentContext::prepare(const doris::TPipelineFragmentParams&
request,
Review Comment:
warning: function 'prepare' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status PipelineXFragmentContext::prepare(const
doris::TPipelineFragmentParams& request,
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:168:** 108
lines including whitespace and comments (threshold 80)
```cpp
Status PipelineXFragmentContext::prepare(const
doris::TPipelineFragmentParams& request,
^
```
</details>
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:
##########
@@ -486,11 +491,14 @@
return Status::OK();
}
-Status PipelineXFragmentContext::_build_pipeline_tasks(
- const doris::TPipelineFragmentParams& request) {
+Status PipelineXFragmentContext::_build_pipeline_x_tasks(
Review Comment:
warning: function '_build_pipeline_x_tasks' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status PipelineXFragmentContext::_build_pipeline_x_tasks(
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:493:** 216
lines including whitespace and comments (threshold 80)
```cpp
Status PipelineXFragmentContext::_build_pipeline_x_tasks(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
