github-actions[bot] commented on code in PR #33870:
URL: https://github.com/apache/doris/pull/33870#discussion_r1571711280


##########
be/src/service/internal_service.cpp:
##########
@@ -625,6 +627,87 @@ void 
PInternalServiceImpl::fetch_data(google::protobuf::RpcController* controlle
     }
 }
 
+void 
PInternalServiceImpl::outfile_write_success(google::protobuf::RpcController* 
controller,

Review Comment:
   warning: method 'outfile_write_success' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
   static void 
PInternalServiceImpl::outfile_write_success(google::protobuf::RpcController* 
controller,
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to