yiguolei commented on code in PR #33853:
URL: https://github.com/apache/doris/pull/33853#discussion_r1570713454
##########
be/src/common/stack_trace.cpp:
##########
@@ -439,7 +439,8 @@ static StackTraceCache& cacheInstance() {
static std::mutex stacktrace_cache_mutex;
-std::string toStringCached(const StackTrace::FramePointers& pointers, size_t
offset, size_t size) {
+std::string toStringCached(const StackTrace::FramePointers& pointers, size_t
offset, size_t size,
Review Comment:
do not modify these very low API, it is very likely to import some bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
