Vallishp commented on code in PR #33264:
URL: https://github.com/apache/doris/pull/33264#discussion_r1570523857
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java:
##########
@@ -770,6 +771,8 @@ public static Optional<Expression>
checkAndMaybeCommute(Expression expression) {
return Optional.ofNullable(predicate.left().isSlot() &&
predicate.right().isLiteral() ? predicate : null);
} else if (expression instanceof IsNull) {
return Optional.ofNullable(((IsNull) expression).child().isSlot()
? expression : null);
+ } else if (expression instanceof StringRegexPredicate) {
+ return Optional.ofNullable(expression);
Review Comment:
have changed logic. pls help to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
