github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1566861450
##########
be/src/vec/columns/column_string.h:
##########
@@ -106,28 +106,28 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
public:
void sanity_check() const;
- bool is_variable_length() const override { return true; }
- const char* get_family_name() const override { return "String"; }
+ bool is_variable_length() const final { return true; }
+ const char* get_family_name() const final { return "String"; }
- size_t size() const override { return offsets.size(); }
+ virtual size_t size() const override { return offsets.size(); }
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
size_t size() const override { return offsets.size(); }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
