yiguolei commented on a change in pull request #7451:
URL: https://github.com/apache/incubator-doris/pull/7451#discussion_r773571349
##########
File path: be/CMakeLists.txt
##########
@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)
# set CMAKE_C_COMPILER, this must set before project command
-if (DEFINED ENV{DORIS_GCC_HOME})
Review comment:
No, We should remove GCC HOME env.
User should only define CC and CXX env,
for example
export CC= XXXXXXXXXX
export CXX=xxxxxxxxxxxxxx
We define GCC HOME because bitshuffle's build process depend on GCC_HOME/ld.
I will rewrite bitshuffle build method use cmake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
