github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1565309117
##########
be/src/vec/columns/column_string.cpp:
##########
@@ -308,6 +357,16 @@
return max_size + sizeof(uint32_t);
}
+size_t ColumnLargeStringForJoin::get_max_row_byte_size() const {
Review Comment:
warning: method 'get_max_row_byte_size' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_string.h:610:
```diff
- size_t get_max_row_byte_size() const override;
+ static size_t get_max_row_byte_size() override;
```
```suggestion
size_t ColumnLargeStringForJoin::get_max_row_byte_size() {
```
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -251,6 +251,15 @@ void ColumnStruct::insert_range_from(const IColumn& src,
size_t start, size_t le
}
}
+void ColumnStruct::insert_range_from_ignore_overflow(const IColumn& src,
size_t start,
Review Comment:
warning: method 'insert_range_from_ignore_overflow' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:147:
```diff
- void insert_range_from_ignore_overflow(const IColumn& src, size_t
start,
+ static void insert_range_from_ignore_overflow(const IColumn& src,
size_t start,
```
##########
be/src/vec/columns/column_string.cpp:
##########
@@ -284,6 +319,20 @@ StringRef ColumnString::serialize_value_into_arena(size_t
n, Arena& arena,
return res;
}
+StringRef ColumnLargeStringForJoin::serialize_value_into_arena(size_t n,
Arena& arena,
Review Comment:
warning: method 'serialize_value_into_arena' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_string.h:605:
```diff
- StringRef serialize_value_into_arena(size_t n, Arena& arena, char
const*& begin) const override;
+ static StringRef serialize_value_into_arena(size_t n, Arena& arena,
char const*& begin) override;
```
be/src/vec/columns/column_string.cpp:322:
```diff
- char
const*& begin) const {
+ char
const*& begin) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
