github-actions[bot] commented on code in PR #33173:
URL: https://github.com/apache/doris/pull/33173#discussion_r1560817114
##########
be/src/pipeline/exec/distinct_streaming_aggregation_operator.cpp:
##########
@@ -68,6 +69,20 @@
DistinctStreamingAggLocalState::DistinctStreamingAggLocalState(RuntimeState* sta
Status DistinctStreamingAggLocalState::init(RuntimeState* state,
LocalStateInfo& info) {
RETURN_IF_ERROR(Base::init(state, info));
SCOPED_TIMER(Base::exec_time_counter());
+ _build_timer = ADD_TIMER(Base::profile(), "BuildTime");
+ _exec_timer = ADD_TIMER(Base::profile(), "ExecTime");
+ _hash_table_compute_timer = ADD_TIMER(Base::profile(),
"HashTableComputeTime");
+ _hash_table_emplace_timer = ADD_TIMER(Base::profile(),
"HashTableEmplaceTime");
+ _hash_table_input_counter = ADD_COUNTER(Base::profile(),
"HashTableInputCount", TUnit::UNIT);
+ _hash_table_size_counter = ADD_COUNTER(profile(), "HashTableSize",
TUnit::UNIT);
+ _insert_keys_to_column_timer = ADD_TIMER(profile(),
"InsertKeysToColumnTime");
+ return Status::OK();
+}
+
+Status DistinctStreamingAggLocalState::open(RuntimeState* state) {
Review Comment:
warning: method 'open' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status DistinctStreamingAggLocalState::open(RuntimeState* state) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
