yangzhg commented on a change in pull request #7131: URL: https://github.com/apache/incubator-doris/pull/7131#discussion_r767384477
########## File path: be/src/runtime/fragment_mgr.h ########## @@ -58,7 +58,7 @@ class FragmentMgr : public RestMonitorIface { using FinishCallback = std::function<void(PlanFragmentExecutor*)>; FragmentMgr(ExecEnv* exec_env); - virtual ~FragmentMgr(); + virtual ~FragmentMgr();//why virtual dtor? Review comment: ```suggestion virtual ~FragmentMgr(); // why virtual dtor? ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org