JNSimba commented on pull request #7210: URL: https://github.com/apache/incubator-doris/pull/7210#issuecomment-990720594
> > Thank you very much, it works. It is what I wanted. > > Another question, how about the flink sink only supports `json` format? > > The `Doris Sink` and `DorisDynamicOutputFormat` could be more unified and not puzzled, eg: > > `DataStream` > > now > > ``` > properties.setProperty("format", "json"); > properties.setProperty("strip_outer_array", "true/false"); > properties.setProperty("columns", "id, name, __DORIS_DELETE_SIGN__"); > ``` > > after > > ``` > properties.setProperty("strip_outer_array", "true/false"); > properties.setProperty("columns", "id, name, __DORIS_DELETE_SIGN__"); > ``` > > `Table(SQL)` now The table data is `Rowdata` and the doris-flink writes it to doris. The `format` is defined or not, it is all ok. What is the different? > > If all of that is ok , I am willing to finish it. > > The `streamload` is very powerful, and the `setStreamLoadProp()` is also very powerful :) > > Thank you very much again. Using json format data can indeed avoid many problems. I think to modify the default data format of streamload to json format is better As for the csv format, it can be left to users to choose freely, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org