yiguolei commented on code in PR #33331:
URL: https://github.com/apache/doris/pull/33331#discussion_r1555158093


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -1609,4 +1620,55 @@ void 
FragmentMgr::get_runtime_query_info(std::vector<WorkloadQueryInfo>* query_i
     }
 }
 
+Status FragmentMgr::get_realtime_exec_status(const TUniqueId& query_id,
+                                             
std::shared_ptr<TReportExecStatusParams> exes_status) {

Review Comment:
   std::shared_ptr<TReportExecStatusParams>* exes_status
   OR the value will not be returned.
   And you could also use std::shared_ptr<TReportExecStatusParams>&, but I do 
not think we could use it like this. Because in doris, we use pointer as return 
values, and reference as input parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to