yiguolei commented on code in PR #33295:
URL: https://github.com/apache/doris/pull/33295#discussion_r1554811856
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -119,7 +119,12 @@ ColumnArray::ColumnArray(MutableColumnPtr&& nested_column)
: data(std::move(nest
}
MutableColumnPtr ColumnArray::get_shrinked_column() {
- return ColumnArray::create(data->get_shrinked_column(),
offsets->assume_mutable());
+ if (data->is_column_string() || data->is_column_array() ||
data->is_column_map() ||
Review Comment:
Not do like this. If we add another type that need shrink, we may forget to
modify this place.
We could add a new virtual method in column.h bool could_shrink()
and use it in get_shrinked_column to check if need call get_shrinked_column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
