This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new a8596ecf3e9 [fix](UT) Fix incorrect command for cloud run_all_tests.sh 
(#33274)
a8596ecf3e9 is described below

commit a8596ecf3e917996dcbee61c7e2a7b58056be2c3
Author: Gavin Chou <gavineaglec...@gmail.com>
AuthorDate: Sat Apr 6 18:20:43 2024 +0800

    [fix](UT) Fix incorrect command for cloud run_all_tests.sh (#33274)
---
 cloud/script/run_all_tests.sh | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/cloud/script/run_all_tests.sh b/cloud/script/run_all_tests.sh
index b8367c2e15a..3e73ec00b27 100644
--- a/cloud/script/run_all_tests.sh
+++ b/cloud/script/run_all_tests.sh
@@ -104,21 +104,23 @@ echo "DORIS_JAVA_HOME=${DORIS_JAVA_HOME}"
 
 export LD_LIBRARY_PATH="${DORIS_JAVA_HOME}/lib/server:${LD_LIBRARY_PATH}"
 
+# disable some STUPID shell-check rules for this function
+# shellcheck disable=SC2048,SC2068,SC2086,SC2155,SC2248
 # report converage for unittest
 # input param is unittest binary file list
 function report_coverage() {
     local binary_objects=$1
     local profdata="./report/doris_cloud.profdata"
-    profraw=$(ls ./report/*.profraw)
+    local profraw=$(ls ./report/*.profraw)
     local binary_objects_options=()
-    for object in "${binary_objects[@]}"; do
+    for object in ${binary_objects[@]}; do
         binary_objects_options[${#binary_objects_options[*]}]="-object 
${object}"
     done
-    llvm-profdata merge -o "${profdata}" "${profraw}"
+    llvm-profdata merge -o ${profdata} ${profraw}
     llvm-cov show -output-dir=report -format=html \
         -ignore-filename-regex='(.*gensrc/.*)|(.*_test\.cpp$)' \
-        -instr-profile="${profdata}" \
-        "${binary_objects_options[*]}"
+        -instr-profile=${profdata} \
+        ${binary_objects_options[*]}
 }
 
 export LSAN_OPTIONS=suppressions=./lsan_suppression.conf
@@ -151,4 +153,4 @@ if [[ "_${ENABLE_CLANG_COVERAGE}" == "_ON" ]]; then
     report_coverage "${unittest_files[*]}"
 fi
 
-# vim: et ts=2 sw=2:
+# vim: et ts=4 sw=4:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to