github-actions[bot] commented on code in PR #33281:
URL: https://github.com/apache/doris/pull/33281#discussion_r1554535769
##########
be/src/io/cache/block_file_cache_factory.cpp:
##########
@@ -118,17 +118,12 @@ FileCacheFactory::get_query_context_holders(const
TUniqueId& query_id) {
return holders;
}
-void FileCacheFactory::clear_file_caches(bool sync) {
+std::string FileCacheFactory::clear_file_caches(bool sync) {
Review Comment:
warning: method 'clear_file_caches' can be made static
[readability-convert-member-functions-to-static]
be/src/io/cache/block_file_cache_factory.h:68:
```diff
- std::string clear_file_caches(bool sync);
+ static std::string clear_file_caches(bool sync);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
