github-actions[bot] commented on code in PR #33223: URL: https://github.com/apache/doris/pull/33223#discussion_r1549286092
########## be/src/pipeline/exec/file_scan_operator.h: ########## @@ -79,6 +79,8 @@ class FileScanOperatorX final : public ScanOperatorX<FileScanLocalState> { Status prepare(RuntimeState* state) override; + bool is_file_scan_operator() const override { return true; } Review Comment: warning: method 'is_file_scan_operator' can be made static [readability-convert-member-functions-to-static] ```suggestion static bool is_file_scan_operator() override { return true; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org