deardeng commented on code in PR #32759:
URL: https://github.com/apache/doris/pull/32759#discussion_r1549086314


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -6130,6 +6137,23 @@ public void checkReadyOrThrowTException() throws 
TException {
         }
     }
 
+    public void createStage(CreateStageStmt stmt) throws DdlException {

Review Comment:
   放到cloudEnv.java中



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -6130,6 +6137,23 @@ public void checkReadyOrThrowTException() throws 
TException {
         }
     }
 
+    public void createStage(CreateStageStmt stmt) throws DdlException {
+        if (Config.isNotCloudMode()) {
+            throw new DdlException("stage is only supported in cloud mode");
+        }
+        if (!stmt.isDryRun()) {
+            getInternalCatalog().createStage(stmt.toStageProto(), 
stmt.isIfNotExists());
+        }
+    }
+
+    public void dropStage(DropStageStmt stmt) throws DdlException {

Review Comment:
   ditto



##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -3512,4 +3521,337 @@ public void 
replayAutoIncrementIdUpdateLog(AutoIncrementIdUpdateLog log) throws
     public boolean enableAutoAnalyze() {
         return true;
     }
+
+    public void createStage(Cloud.StagePB stagePB, boolean ifNotExists) throws 
DdlException {

Review Comment:
   放到cloudInternalcatalog.java中



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to