github-actions[bot] commented on code in PR #33209:
URL: https://github.com/apache/doris/pull/33209#discussion_r1549009504
##########
be/src/exec/tablet_info.h:
##########
@@ -88,6 +88,10 @@
std::set<std::string> partial_update_input_columns() const {
return _partial_update_input_columns;
}
+ void set_timestamp_ms(int64_t timestamp_ms) { _timestamp_ms =
timestamp_ms; }
+ int64_t timestamp_ms() const { return _timestamp_ms; }
+ void set_timezone(std::string timezone) { _timezone = timezone; }
+ std::string timezone() const { return _timezone; }
Review Comment:
warning: function 'timezone' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::string timezone() const { return _timezone; }
```
##########
be/src/exec/tablet_info.h:
##########
@@ -88,6 +88,10 @@ class OlapTableSchemaParam {
std::set<std::string> partial_update_input_columns() const {
return _partial_update_input_columns;
}
+ void set_timestamp_ms(int64_t timestamp_ms) { _timestamp_ms =
timestamp_ms; }
+ int64_t timestamp_ms() const { return _timestamp_ms; }
Review Comment:
warning: function 'timestamp_ms' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int64_t timestamp_ms() const { return _timestamp_ms; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
