github-actions[bot] commented on code in PR #33164:
URL: https://github.com/apache/doris/pull/33164#discussion_r1548877698
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2669,5 +2671,11 @@ bool SegmentIterator::_need_read_key_data(ColumnId cid,
vectorized::MutableColum
return true;
}
+bool SegmentIterator::_has_delete_predicate(ColumnId cid) {
Review Comment:
warning: method '_has_delete_predicate' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/segment_iterator.h:380:
```diff
- bool _has_delete_predicate(ColumnId cid);
+ static bool _has_delete_predicate(ColumnId cid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
