zhiqiang-hhhh commented on code in PR #33132:
URL: https://github.com/apache/doris/pull/33132#discussion_r1547336369
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -597,6 +593,7 @@ void ExecEnv::destroy() {
_delta_writer_v2_pool.reset();
_load_stream_stub_pool.reset();
_file_cache_open_fd_cache.reset();
+ _write_cooldown_meta_executors.reset();
Review Comment:
call `_write_cooldown_meta_executors.stop();` before it is destoried. and
the calling of this function should be move forward.
##########
be/src/olap/tablet.h:
##########
@@ -84,6 +80,27 @@ enum TabletStorageType { STORAGE_TYPE_LOCAL,
STORAGE_TYPE_REMOTE, STORAGE_TYPE_R
static inline constexpr auto TRACE_TABLET_LOCK_THRESHOLD =
std::chrono::seconds(1);
+struct WriteCooldownMetaExecutors {
+ WriteCooldownMetaExecutors(size_t executor_nums = 5);
+
+ ~WriteCooldownMetaExecutors();
+
+ void submit(TabletSharedPtr tablet);
Review Comment:
add a method `void stop()`, which stops all the executors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
