github-actions[bot] commented on code in PR #33126: URL: https://github.com/apache/doris/pull/33126#discussion_r1547306672
########## be/src/vec/core/block.cpp: ########## @@ -728,6 +728,64 @@ void Block::shuffle_columns(const std::vector<int>& result_column_ids) { swap(Block {tmp_data}); } +void Block::copy_block_from_result_column_id(Block& input_block, Review Comment: warning: method 'copy_block_from_result_column_id' can be made const [readability-make-member-function-const] be/src/vec/core/block.cpp:732: ```diff - bool keep_origin) { + bool keep_origin) const { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org