github-actions[bot] commented on code in PR #33130:
URL: https://github.com/apache/doris/pull/33130#discussion_r1547102381
##########
be/src/vec/columns/column_array.h:
##########
@@ -126,6 +126,7 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
std::string get_name() const override;
const char* get_family_name() const override { return "Array"; }
bool is_column_array() const override { return true; }
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: method 'is_variable_length' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool is_variable_length() override { return true; }
```
##########
be/src/vec/columns/column_map.h:
##########
@@ -94,6 +94,7 @@ class ColumnMap final : public COWHelper<IColumn, ColumnMap> {
ColumnPtr convert_to_full_column_if_const() const override;
MutableColumnPtr clone_resized(size_t size) const override;
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: method 'is_variable_length' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool is_variable_length() override { return true; }
```
##########
be/src/vec/columns/column_string.h:
##########
@@ -106,7 +106,7 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
public:
void sanity_check() const;
-
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: method 'is_variable_length' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool is_variable_length() override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
