github-actions[bot] commented on code in PR #33025:
URL: https://github.com/apache/doris/pull/33025#discussion_r1544204491
##########
be/src/vec/olap/vertical_block_reader.h:
##########
@@ -68,6 +68,10 @@ class VerticalBlockReader final : public TabletReader {
static uint64_t nextId;
+ void set_missing_group(bool missing_group) { _missing_group =
missing_group; }
+
+ bool get_missing_group() { return _missing_group; }
Review Comment:
warning: method 'get_missing_group' can be made const
[readability-make-member-function-const]
```suggestion
bool get_missing_group() const { return _missing_group; }
```
##########
be/src/olap/rowset/segcompaction.cpp:
##########
@@ -243,6 +251,14 @@ Status
SegcompactionWorker::_do_compact_segments(SegCompactionCandidatesSharedPt
VLOG_NOTICE << "row source size: " << row_sources_buf.total_size();
bool is_key = (i == 0);
std::vector<uint32_t> column_ids = column_groups[i];
+ int count = 0;
+ for (auto cid : column_ids) {
+ if (!missing_cid_set.contains(cid)) {
+ break;
+ }
+ count++;
+ }
+ bool is_missing_groups = !column_ids.empty() && count ==
column_ids.size() ? true : false;
Review Comment:
warning: redundant boolean literal in ternary expression result
[readability-simplify-boolean-expr]
```suggestion
bool is_missing_groups = static_cast<bool>(!column_ids.empty() &&
count == column_ids.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
