morningman commented on code in PR #32824:
URL: https://github.com/apache/doris/pull/32824#discussion_r1540716393
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/HiveInsertExecutor.java:
##########
@@ -116,10 +117,26 @@ protected void onFail(Throwable t) {
}
ctx.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR,
sb.toString());
}
+ ctx.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR, t.getMessage());
Review Comment:
Missing `else`? This will overwrite the msg in line 118
##########
regression-test/suites/external_table_p0/hive/write/test_hive_write_insert.groovy:
##########
@@ -729,21 +726,19 @@ suite("test_hive_write_insert",
"p0,external,hive,external_docker,external_docke
"""
order_qt_q02 """ select * from
all_types_par_${format_compression}_${catalog_name}_q03;
"""
-// disable it temporarily
-// sql """refresh catalog ${catalog_name};"""
-
-// sql """
-// INSERT INTO
all_types_par_${format_compression}_${catalog_name}_q03(float_col, t_map_int,
t_array_decimal_precision_8, t_array_string_starting_with_nulls, dt)
-// VALUES (
-// CAST(123.45 AS FLOAT), -- float_col
-// MAP(CAST(1 AS INT), CAST(10 AS INT)), -- t_map_int
-// ARRAY(CAST(1.2345 AS DECIMAL(8,4)), CAST(2.3456 AS DECIMAL(8,4))),
-- t_array_decimal_precision_8
-// ARRAY(null, CAST('value1' AS STRING), CAST('value2' AS STRING)),
-- t_array_string_starting_with_nulls
-// 20240321 -- dt
-// );
-// """
-// order_qt_q03 """ select * from
all_types_par_${format_compression}_${catalog_name}_q03;
-// """
+
+ sql """
+ INSERT INTO
all_types_par_${format_compression}_${catalog_name}_q03(float_col, t_map_int,
t_array_decimal_precision_8, t_array_string_starting_with_nulls, dt)
+ VALUES (
+ CAST(123.45 AS FLOAT), -- float_col
Review Comment:
Remove `cast`?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -197,6 +198,10 @@ private void runInternal(ConnectContext ctx, StmtExecutor
executor) throws Excep
insertExecutor.executeSingleInsert(executor, jobId);
}
+ public boolean isExternalTableSink() {
+ return logicalQuery instanceof UnboundHiveTableSink;
Review Comment:
```suggestion
return !(logicalQuery instanceof UnboundTableSink);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
