yiguolei commented on code in PR #32783:
URL: https://github.com/apache/doris/pull/32783#discussion_r1540365070
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -575,7 +577,9 @@ struct HashJoinSharedState : public JoinSharedState {
bool probe_ignore_null = false;
};
-struct PartitionedHashJoinSharedState : public HashJoinSharedState {
+struct PartitionedHashJoinSharedState
+ : public HashJoinSharedState,
+ public std::enable_shared_from_this<PartitionedHashJoinSharedState> {
std::vector<std::unique_ptr<vectorized::MutableBlock>>
partitioned_build_blocks;
Review Comment:
please add enable_factory_creator for this object to forbidden raw pointer
for this object。
And also using class not struct. I am not sure if enable_factory_creator has
effect on struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
