zhannngchen commented on code in PR #32200:
URL: https://github.com/apache/doris/pull/32200#discussion_r1539234583
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -689,8 +689,11 @@ Status VerticalSegmentWriter::batch_block(const
vectorized::Block* block, size_t
_opts.rowset_ctx->partial_update_info->is_partial_update &&
_opts.write_type == DataWriteType::TYPE_DIRECT &&
!_opts.rowset_ctx->is_transient_rowset_writer) {
- if (block->columns() <= _tablet_schema->num_key_columns() ||
- block->columns() >= _tablet_schema->num_columns()) {
+ if ((_tablet_schema->keys_type() == UNIQUE_KEYS &&
Review Comment:
you should also consider SegmentWriter class, it has same method and code
with VerticalSegmentWriter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
