[GitHub] [incubator-doris] morningman commented on a change in pull request #7126: [enhancement] Optimize the fail logic of loading data when some backend failed

[GitBox]

morningman commented on a change in pull request #7126:
URL: https://github.com/apache/incubator-doris/pull/7126#discussion_r749882831



##########
File path: be/src/exec/tablet_sink.h
##########
@@ -295,8 +305,10 @@ class IndexChannel {
     std::unordered_map<int64_t, NodeChannel*> _node_channels;
     // from tablet_id to backend channel
     std::unordered_map<int64_t, std::vector<NodeChannel*>> _channels_by_tablet;
+    // from backend channel to tablet_id
+    std::unordered_map<int64_t, std::set<int64_t>> _tablets_by_channel;

Review comment:
       ```suggestion
       std::unordered_map<int64_t, std::unordered_set<int64_t>> 
_tablets_by_channel;
   ```

##########
File path: be/src/exec/tablet_sink.h
##########
@@ -295,8 +305,10 @@ class IndexChannel {
     std::unordered_map<int64_t, NodeChannel*> _node_channels;
     // from tablet_id to backend channel
     std::unordered_map<int64_t, std::vector<NodeChannel*>> _channels_by_tablet;
+    // from backend channel to tablet_id
+    std::unordered_map<int64_t, std::set<int64_t>> _tablets_by_channel;
     // BeId

Review comment:
       modify comment

##########
File path: be/src/exec/tablet_sink.h
##########
@@ -295,8 +305,10 @@ class IndexChannel {
     std::unordered_map<int64_t, NodeChannel*> _node_channels;
     // from tablet_id to backend channel
     std::unordered_map<int64_t, std::vector<NodeChannel*>> _channels_by_tablet;
+    // from backend channel to tablet_id
+    std::unordered_map<int64_t, std::set<int64_t>> _tablets_by_channel;
     // BeId
-    std::set<int64_t> _failed_channels;
+    std::unordered_map<int64_t, std::set<int64_t>> _failed_channels;

Review comment:
       ```suggestion
       std::unordered_map<int64_t, std::unordered_set<int64_t>> 
_failed_channels;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org