morningman commented on a change in pull request #6974: URL: https://github.com/apache/incubator-doris/pull/6974#discussion_r747435862
########## File path: be/src/exec/es/es_scroll_parser.cpp ########## @@ -426,19 +426,24 @@ Status ScrollParser::fill_tuple(const TupleDescriptor* tuple_desc, Tuple* tuple, *reinterpret_cast<int8_t*>(slot) = col.GetInt(); break; } - if (pure_doc_value && col.IsArray()) { + + bool is_nested_str = false; + if (pure_doc_value && col.IsArray() && col[0].IsBool()) { *reinterpret_cast<int8_t*>(slot) = col[0].GetBool(); break; + } else if (pure_doc_value && col.IsArray() && col[0].IsString()) { + is_nested_str = true; + } else if (pure_doc_value && col.IsArray()) { Review comment: I think we can extract the common expression `pure_doc_value && col.IsArray()` to reduce the judgement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org