github-actions[bot] commented on code in PR #32588:
URL: https://github.com/apache/doris/pull/32588#discussion_r1533203882
##########
be/src/vec/functions/function_string.h:
##########
@@ -1174,6 +1177,14 @@ class FunctionStringRepeat : public IFunction {
static FunctionPtr create() { return
std::make_shared<FunctionStringRepeat>(); }
String get_name() const override { return name; }
size_t get_number_of_arguments() const override { return 2; }
+ std::string error_msg(int default_value, int repeat_value) const {
Review Comment:
warning: function 'error_msg' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::string error_msg(int default_value, int repeat_value)
const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
