suxiaogang223 commented on code in PR #32438:
URL: https://github.com/apache/doris/pull/32438#discussion_r1531726352
##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -728,28 +729,40 @@ Status StructColumnReader::read_column_data(ColumnPtr&
doris_column, DataTypePtr
}
auto& doris_struct = static_cast<ColumnStruct&>(*data_column);
- if (_child_readers.size() != doris_struct.tuple_size()) {
- return Status::InternalError("Wrong number of struct fields");
- }
const DataTypeStruct* doris_struct_type =
reinterpret_cast<const
DataTypeStruct*>(remove_nullable(type).get());
- for (int i = 0; i < doris_struct.tuple_size(); ++i) {
+
+ bool least_one_reader = false;
+ size_t least_one_idx = 0;
+ std::vector<size_t> missing_column_idxs {};
+
+ for (size_t i = 0; i < doris_struct.tuple_size(); ++i) {
ColumnPtr& doris_field = doris_struct.get_column_ptr(i);
DataTypePtr& doris_type =
const_cast<DataTypePtr&>(doris_struct_type->get_element(i));
+ String& doris_name =
const_cast<String&>(doris_struct_type->get_element_name(i));
Review Comment:
The doris_name is always lower case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
