xzj7019 commented on code in PR #32305:
URL: https://github.com/apache/doris/pull/32305#discussion_r1531454266
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/PullUpProjectUnderLimitTest.java:
##########
@@ -35,14 +36,16 @@
class PullUpProjectUnderLimitTest implements MemoPatternMatchSupported {
private final LogicalOlapScan scan1 =
PlanConstructor.newLogicalOlapScan(0, "t1", 0);
+ private final LogicalOlapScan scan2 =
PlanConstructor.newLogicalOlapScan(1, "t2", 0);
@Test
void test() {
List<NamedExpression> exprs = ImmutableList.of(
- scan1.getOutput().get(0),
+ scan1.getOutput().get(0).alias("id"),
new Cast(scan1.getOutput().get(1),
VarcharType.SYSTEM_DEFAULT).alias("cast")
);
LogicalPlan limit = new LogicalPlanBuilder(scan1)
+ .join(scan2, JoinType.LEFT_OUTER_JOIN, ImmutableList.of())
Review Comment:
Do we need to cover right outer and cross? since the code handle these two
kinds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
