[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #7048: [Compile] Fix spark-connector compile problem

[GitBox]

chovy-3012 commented on a change in pull request #7048:
URL: https://github.com/apache/incubator-doris/pull/7048#discussion_r744556447



##########
File path: thirdparty/build-thirdparty.sh
##########
@@ -256,6 +256,8 @@ build_thrift() {
     fi
 
     make -j $PARALLEL && make install
+    # Create soft link under `/usr/bin`
+    ln -s /var/local/thirdparty/installed/bin/thrift /usr/bin/thrift

Review comment:
       How about specifying `thrift` path in POM file, like this:
   ```xml
    <plugin>
                   <groupId>org.apache.thrift.tools</groupId>
                   <artifactId>maven-thrift-plugin</artifactId>
                   <version>0.1.11</version>
                   <configuration>
                       
<thriftExecutable>/var/local/thirdparty/installed/bin/thrift</thriftExecutable>
   ```
   
   or in `build.sh` script ,like this:
   ```sh
   export PATH=/var/local/thirdparty/installed/bin:$PATH:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org