HappenLee commented on a change in pull request #6971:
URL: https://github.com/apache/incubator-doris/pull/6971#discussion_r744450847
##########
File path: be/src/olap/hll.h
##########
@@ -154,7 +174,7 @@ class HyperLogLog {
HllDataType _type = HLL_DATA_EMPTY;
uint32_t _explicit_data_num = 0;
- uint64_t _explicit_data[HLL_EXPLICIT_INT64_NUM * 2];
+ uint64_t* _explicit_data = nullptr;
Review comment:
directly use the raw ptr is dangerous and complex. Rethink should we
replace it by std::unique_ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
